Ar-code Plugins

Comments and changes to this ticket

• You flagged this item as spam.
  

  steve odom December 28th, 2007 @ 12:23 PM

  Following up on what Schwab said above for using will_paginate, here's what I did:

  I replaced line 34 in the logged_exceptions controller with:

  @exceptions = LoggedException.paginate :order => 'created_at desc', :page => params[:page], :per_page => 30, 
          :conditions => conditions.empty? ? nil : parameters.unshift(conditions * ' and ')
  
  

  And in the _exceptions.rhtml partial I replaced the 2 pagination divs at the top and bottom that look like this:

  <% if @exception_pages.page_count > 1 %>
  <div class="pages pages-bottom">
  Pages: <strong><%= pagination_remote_links @exception_pages, :params => { :action => :index } %></strong>
  </div>
  <% end %>
  

  With:

  <div class="pages pages-bottom">
  Pages: <strong><%= will_paginate @exceptions -%></strong>
  </div>
  

• You flagged this item as spam.
  

  Sudara January 23rd, 2008 @ 09:19 AM

  Just want to add that those changes make it rails 2 friendly and working.

  Only other thing to note is that it might help a few folks out to add the following route to the readme:

  map.logged_exceptions 'logged_exceptions/:action/:id',    :controller => 'logged_exceptions'
  

• You flagged this item as spam.
  

  Sudara January 23rd, 2008 @ 10:32 AM

  whups, one more thing:

  the readme could also note that for most new apps (rails 2), you'll need to also include protect_from_forgery.

• 

  Rick January 27th, 2008 @ 02:22 PM

  • State changed from “new” to “open”

  Hey, I guess I don't check this often enough. Chris Wanstrath made an enhancement to the plugin that uses will_paginate. I plan on cherry picking that commit.

  Sudara: where are you adding #protect_from_forgery? I'm not keen on adding it to the plugin if it'll break Rails 1.2 users.

• You flagged this item as spam.
  

  Sudara January 27th, 2008 @ 05:19 PM

  ahoy.

  Sorry for that. Maybe I'm on crack, but I needed it hanging out in production.rb - Not a biggie, but worth mentioning in that nice readme of yours.

  Thanks